Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expiry tag #2618

Merged
merged 27 commits into from Jul 18, 2023
Merged

Fix expiry tag #2618

merged 27 commits into from Jul 18, 2023

Conversation

Jayashsatolia403
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Jayashsatolia403 Jayashsatolia403 changed the base branch from staging to sprint-july-2 July 12, 2023 18:23
@Jayashsatolia403 Jayashsatolia403 changed the base branch from sprint-july-2 to staging July 16, 2023 16:06
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jayashsatolia403 Jayashsatolia403 changed the base branch from staging to sprint-july-3 July 18, 2023 10:20
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (sprint-july-3@7eab8e3). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff                @@
##             sprint-july-3    #2618   +/-   ##
================================================
  Coverage                 ?   28.86%           
================================================
  Files                    ?      383           
  Lines                    ?    64346           
  Branches                 ?        0           
================================================
  Hits                     ?    18571           
  Misses                   ?    43579           
  Partials                 ?     2196           
Flag Coverage Δ
Unit-Tests 28.86% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kishan-Dhakan Kishan-Dhakan merged commit 3ccca75 into sprint-july-3 Jul 18, 2023
5 of 7 checks passed
@Kishan-Dhakan Kishan-Dhakan deleted the fix/expiry-tag branch July 18, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change expiry to expiration + timeUnit on extend in updateAllocationRequestInternal
4 participants