Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Readpool index #2620

Merged
merged 8 commits into from Jul 22, 2023
Merged

Add Readpool index #2620

merged 8 commits into from Jul 22, 2023

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented Jul 13, 2023

Fixes

Add index to readpool

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Sriep Sriep changed the base branch from staging to sprint-july-2 July 13, 2023 09:20
@Sriep Sriep changed the base branch from sprint-july-2 to sprint-july-3 July 17, 2023 09:01
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain readpool_pk
blobber
authorizer
0box
0dns

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain readpool_pk
blobber
authorizer
0box
0dns

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (sprint-july-3@d10be1a). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff                @@
##             sprint-july-3    #2620   +/-   ##
================================================
  Coverage                 ?   28.79%           
================================================
  Files                    ?      383           
  Lines                    ?    64552           
  Branches                 ?        0           
================================================
  Hits                     ?    18589           
  Misses                   ?    43765           
  Partials                 ?     2198           
Flag Coverage Δ
Unit-Tests 28.79% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dabasov dabasov merged commit bead7c4 into sprint-july-3 Jul 22, 2023
7 checks passed
@dabasov dabasov deleted the readpool_pk branch July 22, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants