Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added id and type #2661

Merged
merged 4 commits into from Aug 8, 2023
Merged

added id and type #2661

merged 4 commits into from Aug 8, 2023

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Jul 30, 2023

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

Codecov Report

Merging #2661 (a1385b5) into staging (1d0477f) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           staging    #2661      +/-   ##
===========================================
+ Coverage    28.73%   28.75%   +0.01%     
===========================================
  Files          385      385              
  Lines        64741    64744       +3     
===========================================
+ Hits         18605    18615      +10     
+ Misses       43911    43898      -13     
- Partials      2225     2231       +6     
Flag Coverage Δ
Unit-Tests 28.75% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...e/go/0chain.net/smartcontract/storagesc/handler.go 5.69% <0.00%> (-0.01%) ⬇️

... and 5 files with indirect coverage changes

@dabasov dabasov changed the base branch from staging to sprint-july-4 July 31, 2023 14:53
@dabasov dabasov merged commit d30c4e9 into sprint-july-4 Aug 8, 2023
6 of 7 checks passed
@dabasov dabasov deleted the hotfix/delegate-parameters branch August 8, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants