Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Case 3 and case 4 #2675

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Add Case 3 and case 4 #2675

merged 3 commits into from
Sep 13, 2023

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Aug 4, 2023

Fixes

This PR is in draft state. It needs to add last two cases of #2559.
Currently case 3 is add but is yet to be tested. Case 4 is similar to case-3.

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@lpoli lpoli mentioned this pull request Aug 4, 2023
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #2675 (7ad58e4) into sprint-1.11 (4b5b860) will decrease coverage by 0.01%.
The diff coverage is 63.63%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@               Coverage Diff               @@
##           sprint-1.11    #2675      +/-   ##
===============================================
- Coverage        28.54%   28.53%   -0.01%     
===============================================
  Files              390      391       +1     
  Lines            65593    65612      +19     
===============================================
+ Hits             18723    18725       +2     
- Misses           44626    44645      +19     
+ Partials          2244     2242       -2     
Flag Coverage Δ
Unit-Tests 28.53% <63.63%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...go/0chain.net/smartcontract/storagesc/challenge.go 29.52% <ø> (ø)
...hain.net/smartcontract/storagesc/challenge_main.go 40.00% <40.00%> (ø)
code/go/0chain.net/miner/protocol_block.go 20.28% <81.25%> (+0.14%) ⬆️
code/go/0chain.net/miner/protocol_block_main.go 88.23% <100.00%> (+1.56%) ⬆️

... and 4 files with indirect coverage changes

@devyetii devyetii marked this pull request as ready for review August 12, 2023 22:35
@devyetii devyetii changed the base branch from sprint-july-4 to sprint-1.10 August 17, 2023 20:45
@devyetii devyetii changed the base branch from sprint-1.10 to sprint-1.11 September 7, 2023 06:26
@dabasov dabasov merged commit 1843846 into sprint-1.11 Sep 13, 2023
5 of 7 checks passed
@dabasov dabasov deleted the case-3-and-case-4 branch September 13, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants