Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pass rates #2695

Merged
merged 3 commits into from Aug 9, 2023
Merged

Fix pass rates #2695

merged 3 commits into from Aug 9, 2023

Conversation

Jayashsatolia403
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #2695 (53712b2) into sprint-july-4 (9977fe1) will decrease coverage by 0.01%.
The diff coverage is 73.91%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                Coverage Diff                @@
##           sprint-july-4    #2695      +/-   ##
=================================================
- Coverage          28.69%   28.68%   -0.01%     
=================================================
  Files                386      386              
  Lines              65194    65169      -25     
=================================================
- Hits               18705    18696       -9     
+ Misses             44250    44235      -15     
+ Partials            2239     2238       -1     
Flag Coverage Δ
Unit-Tests 28.68% <73.91%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...o/0chain.net/smartcontract/storagesc/allocation.go 52.13% <73.91%> (+0.18%) ⬆️

... and 4 files with indirect coverage changes

@Jayashsatolia403 Jayashsatolia403 merged commit 45a8142 into sprint-july-4 Aug 9, 2023
7 checks passed
@Jayashsatolia403 Jayashsatolia403 deleted the fix/pass-rates branch August 9, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants