Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update allocation #2728

Merged
merged 30 commits into from Aug 22, 2023
Merged

Fix/update allocation #2728

merged 30 commits into from Aug 22, 2023

Conversation

Jayashsatolia403
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Jayashsatolia403 Jayashsatolia403 changed the base branch from staging to sprint-1.10 August 19, 2023 21:11
@Jayashsatolia403 Jayashsatolia403 linked an issue Aug 19, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2023

Codecov Report

Merging #2728 (2b4d656) into sprint-1.10 (e552b27) will decrease coverage by 0.04%.
Report is 1 commits behind head on sprint-1.10.
The diff coverage is 27.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff               @@
##           sprint-1.10    #2728      +/-   ##
===============================================
- Coverage        28.68%   28.64%   -0.04%     
===============================================
  Files              386      386              
  Lines            65126    65181      +55     
===============================================
- Hits             18679    18670       -9     
- Misses           44219    44282      +63     
- Partials          2228     2229       +1     
Flag Coverage Δ
Unit-Tests 28.64% <27.27%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...e/go/0chain.net/smartcontract/storagesc/handler.go 5.98% <0.00%> (+0.05%) ⬆️
...o/0chain.net/smartcontract/storagesc/models_gen.go 34.09% <0.00%> (-0.72%) ⬇️
...o/0chain.net/smartcontract/storagesc/allocation.go 52.30% <48.00%> (-3.38%) ⬇️
...de/go/0chain.net/smartcontract/storagesc/models.go 47.66% <55.55%> (-0.13%) ⬇️
...e/go/0chain.net/smartcontract/storagesc/blobber.go 43.83% <100.00%> (+0.21%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jayashsatolia403 Jayashsatolia403 merged commit 42c82c3 into sprint-1.10 Aug 22, 2023
7 checks passed
@Jayashsatolia403 Jayashsatolia403 deleted the fix/update_allocation branch August 22, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix update allocation blobber terms in update allocation
7 participants