ISSUE#259 Race issue: CollectionMemberField

[platsko]

Closes #259

[Sriep]

It is looking good. I think the lint issue might be resolved by merging in recent master changes.

[platsko]

It is looking good. I think the lint issue might be resolved by merging in recent master changes.

It is already on master HEAD. I tried to restart git actions and got the same result and have not ideas what is going on. )

[Sriep]

You seem to have gained two lint errors in store.go (not sure why)

core/persistencestore/store.go:131:21: Error return value of `datastore.FromJSON` is not checked (errcheck)
		datastore.FromJSON(json, entities[i])
		                  ^
core/persistencestore/store.go:214:14: Error return value is not checked (errcheck)
		initSession(1*time.Second, 0)
		           ^

There is also

core/persistencestore/store.go:64:20: Error return value of `datastore.FromJSON` is not checked (errcheck)
	datastore.FromJSON(json, entity)

but that was already there.

I pulled master run ./docker.local/bin/build.base.sh and docker.local\bin\linter.sh > 1.txt, then pulled issues/259 and run ./docker.local/bin/build.base.sh and docker.local\bin\linter.sh > 2.txt. Then did a difference on the results.

Hmmm, there seem to be other differences as well, maybe adding new files alters the lint algorithm. My head hurts.