Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conductor testing race condition #2793

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

devyetii
Copy link
Collaborator

@devyetii devyetii commented Sep 20, 2023

Fixes

Related discussion: https://0chain.slack.com/archives/C01GMABG2T1/p1695094338460679

Changes

  • Added RWMutex and used anywhere nodes map is used
  • Removed special handling of validator/blobber in Server.State since cannot be useful.

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (sprint-1.11@00a1796). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@              Coverage Diff               @@
##             sprint-1.11    #2793   +/-   ##
==============================================
  Coverage               ?   28.62%           
==============================================
  Files                  ?      392           
  Lines                  ?    65928           
  Branches               ?        0           
==============================================
  Hits                   ?    18874           
  Misses                 ?    44782           
  Partials               ?     2272           
Flag Coverage Δ
Unit-Tests 28.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dabasov dabasov merged commit a21e25c into sprint-1.11 Sep 20, 2023
9 of 10 checks passed
@dabasov dabasov deleted the fix/conductor-tests-race-condition branch September 20, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants