Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node recovery conductor testing #2797

Merged
merged 69 commits into from
Nov 6, 2023
Merged

Conversation

devyetii
Copy link
Collaborator

Fixes

Add conductor tests for the cases when providers crash then come back up clean.

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@devyetii devyetii marked this pull request as draft September 21, 2023 06:43
@devyetii devyetii changed the base branch from staging to sprint-1.11 September 21, 2023 06:44
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #2797 (70e9a43) into sprint-1.11 (b3c28a6) will decrease coverage by 0.05%.
Report is 48 commits behind head on sprint-1.11.
The diff coverage is 18.13%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@               Coverage Diff               @@
##           sprint-1.11    #2797      +/-   ##
===============================================
- Coverage        28.80%   28.76%   -0.05%     
===============================================
  Files              395      397       +2     
  Lines            65842    66009     +167     
===============================================
+ Hits             18967    18985      +18     
- Misses           44581    44726     +145     
- Partials          2294     2298       +4     
Flag Coverage Δ
Unit-Tests 28.76% <18.13%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
code/go/0chain.net/chaincore/chain/config.go 21.49% <100.00%> (+0.36%) ⬆️
code/go/0chain.net/core/config/config.go 0.00% <ø> (ø)
code/go/0chain.net/sharder/chain.go 3.71% <ø> (-0.21%) ⬇️
code/go/0chain.net/sharder/healthcheck_handler.go 100.00% <ø> (ø)
code/go/0chain.net/sharder/stats.go 89.38% <ø> (-0.40%) ⬇️
...ode/go/0chain.net/smartcontract/dbs/event/block.go 7.24% <100.00%> (ø)
code/go/0chain.net/smartcontract/storagesc/sc.go 42.02% <100.00%> (+0.62%) ⬆️
code/go/0chain.net/smartcontract/zcnsc/nodes.go 33.33% <100.00%> (+1.73%) ⬆️
code/go/0chain.net/sharder/protocol_block.go 0.80% <0.00%> (-0.01%) ⬇️
code/go/0chain.net/sharder/protocol_block_main.go 0.00% <0.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

@devyetii devyetii self-assigned this Sep 30, 2023
@devyetii devyetii linked an issue Sep 30, 2023 that may be closed by this pull request
5 tasks
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 4e9410e into sprint-1.11 Nov 6, 2023
7 checks passed
@dabasov dabasov deleted the node-recovery-conductor-testing branch November 6, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test provider sync up with conductor testing
3 participants