Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD manual triggers for test #2798

Merged
merged 4 commits into from
Oct 11, 2023
Merged

ADD manual triggers for test #2798

merged 4 commits into from
Oct 11, 2023

Conversation

tapishsinha-rs
Copy link
Contributor

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #2798 (85ee0ba) into staging (3da98e4) will increase coverage by 0.01%.
Report is 4 commits behind head on staging.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           staging    #2798      +/-   ##
===========================================
+ Coverage    28.51%   28.52%   +0.01%     
===========================================
  Files          390      390              
  Lines        65597    65606       +9     
===========================================
+ Hits         18702    18714      +12     
+ Misses       44661    44651      -10     
- Partials      2234     2241       +7     
Flag Coverage Δ
Unit-Tests 28.52% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
code/go/0chain.net/sharder/chain.go 4.52% <0.00%> (-0.11%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Collaborator

@shahnawaz-creator shahnawaz-creator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrt branch input it looks good to me.
you can make changes into the same PR to run the cron from latest sprint branch.

@tapishsinha-rs
Copy link
Contributor Author

@shahnawaz-creator I have added code for sprint-cron functionality.
What it does is grep branch based on the pattern (sprint-*) and sort them according to committerdate and returns the latest branch matching the criteria

Copy link
Collaborator

@shahnawaz-creator shahnawaz-creator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahnawaz-creator shahnawaz-creator merged commit b9ee740 into staging Oct 11, 2023
5 of 8 checks passed
@shahnawaz-creator shahnawaz-creator deleted the feature/manual-test branch October 11, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants