Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blobber-5 conductor testing workflow #2800

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

devyetii
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Merging #2800 (bfb58d8) into staging (3da98e4) will decrease coverage by 0.01%.
Report is 4 commits behind head on staging.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           staging    #2800      +/-   ##
===========================================
- Coverage    28.51%   28.50%   -0.01%     
===========================================
  Files          390      390              
  Lines        65597    65606       +9     
===========================================
  Hits         18702    18702              
- Misses       44661    44666       +5     
- Partials      2234     2238       +4     
Flag Coverage Δ
Unit-Tests 28.50% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
code/go/0chain.net/sharder/chain.go 4.52% <0.00%> (-0.11%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Collaborator

@shahnawaz-creator shahnawaz-creator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devyetii devyetii changed the base branch from staging to sprint-1.11 October 3, 2023 09:19
@devyetii devyetii merged commit 6031037 into sprint-1.11 Oct 3, 2023
7 checks passed
@devyetii devyetii deleted the wf/blobber-5-conductor-testing branch October 3, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants