Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing nodes stat in miner #2813

Merged
merged 6 commits into from Oct 1, 2023
Merged

Add missing nodes stat in miner #2813

merged 6 commits into from Oct 1, 2023

Conversation

peterlimg
Copy link
Member

Fixes

Changes

  • Add metrics to track the missing state nodes number, time to detect them, and time to sync the missing nodes.

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (sprint-1.11@b1b876e). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@              Coverage Diff               @@
##             sprint-1.11    #2813   +/-   ##
==============================================
  Coverage               ?   28.58%           
==============================================
  Files                  ?      392           
  Lines                  ?    66004           
  Branches               ?        0           
==============================================
  Hits                   ?    18869           
  Misses                 ?    44862           
  Partials               ?     2273           
Flag Coverage Δ
Unit-Tests 28.58% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 4bad45a into sprint-1.11 Oct 1, 2023
5 of 7 checks passed
@dabasov dabasov deleted the feat/state-stat branch October 1, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants