Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark test case - storage.challenge_response #2836

Merged
merged 2 commits into from Oct 7, 2023

Conversation

din-mukhammed
Copy link
Contributor

@din-mukhammed din-mukhammed commented Oct 6, 2023

Fixes

  • Fixed storage.challenge_response by adding missing field initialization in mock challenge generation for benchmarks

image

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (sprint-1.11@d377fdc). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@              Coverage Diff               @@
##             sprint-1.11    #2836   +/-   ##
==============================================
  Coverage               ?   28.58%           
==============================================
  Files                  ?      392           
  Lines                  ?    66051           
  Branches               ?        0           
==============================================
  Hits                   ?    18879           
  Misses                 ?    44898           
  Partials               ?     2274           
Flag Coverage Δ
Unit-Tests 28.58% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 0d72e60 into sprint-1.11 Oct 7, 2023
7 checks passed
@dabasov dabasov deleted the fix/bench-storage-challenge-resp branch October 7, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants