Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minstake #2843

Merged
merged 13 commits into from Oct 10, 2023
Merged

Fix minstake #2843

merged 13 commits into from Oct 10, 2023

Conversation

Jayashsatolia403
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Jayashsatolia403 Jayashsatolia403 changed the base branch from staging to sprint-1.11 October 8, 2023 15:04
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (sprint-1.11@ee39d7d). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@              Coverage Diff               @@
##             sprint-1.11    #2843   +/-   ##
==============================================
  Coverage               ?   28.69%           
==============================================
  Files                  ?      394           
  Lines                  ?    66366           
  Branches               ?        0           
==============================================
  Hits                   ?    19041           
  Misses                 ?    45006           
  Partials               ?     2319           
Flag Coverage Δ
Unit-Tests 28.69% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Jayashsatolia403 Jayashsatolia403 linked an issue Oct 8, 2023 that may be closed by this pull request
@Jayashsatolia403 Jayashsatolia403 changed the title Debug minstake Fix minstake Oct 9, 2023
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain fix/minstake
blobber
authorizer
0box
0dns

code/go/0chain.net/smartcontract/minersc/miner.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/minersc/models.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/minersc/models.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/minersc/settings.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/stakepool/stakepool.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/storagesc/stakepool.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/storagesc/stakepool.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/zcnsc/stakepool.go Outdated Show resolved Hide resolved
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit d642430 into sprint-1.11 Oct 10, 2023
5 of 8 checks passed
@dabasov dabasov deleted the fix/minstake branch October 10, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test MinStakePerDelegate
4 participants