Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/transaction #2868

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Fix/transaction #2868

merged 4 commits into from
Oct 16, 2023

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Oct 14, 2023

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@dabasov dabasov changed the base branch from staging to sprint-1.11 October 14, 2023 15:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (sprint-1.11@a98fd7a). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@              Coverage Diff               @@
##             sprint-1.11    #2868   +/-   ##
==============================================
  Coverage               ?   28.71%           
==============================================
  Files                  ?      394           
  Lines                  ?    66342           
  Branches               ?        0           
==============================================
  Hits                   ?    19052           
  Misses                 ?    44971           
  Partials               ?     2319           
Flag Coverage Δ
Unit-Tests 28.71% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dabasov dabasov merged commit 2bde5d3 into sprint-1.11 Oct 16, 2023
7 checks passed
@dabasov dabasov deleted the fix/transaction branch October 16, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants