Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for roll back allocation tokenomics #2878

Merged
merged 6 commits into from Oct 20, 2023
Merged

Conversation

Jayashsatolia403
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Jayashsatolia403 Jayashsatolia403 linked an issue Oct 17, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (sprint-1.11@b6384d4). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@              Coverage Diff               @@
##             sprint-1.11    #2878   +/-   ##
==============================================
  Coverage               ?   28.70%           
==============================================
  Files                  ?      394           
  Lines                  ?    66308           
  Branches               ?        0           
==============================================
  Hits                   ?    19037           
  Misses                 ?    44965           
  Partials               ?     2306           
Flag Coverage Δ
Unit-Tests 28.70% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Jayashsatolia403 Jayashsatolia403 removed the request for review from Hitenjain14 October 18, 2023 09:26
@Jayashsatolia403 Jayashsatolia403 changed the title Added unit tests for roll back allocation Added unit tests for roll back allocation tokenomics\ Oct 18, 2023
@Jayashsatolia403 Jayashsatolia403 changed the title Added unit tests for roll back allocation tokenomics\ Added unit tests for roll back allocation tokenomics Oct 18, 2023
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit e4ba6cc into sprint-1.11 Oct 20, 2023
7 checks passed
@dabasov dabasov deleted the ut/rollback branch October 20, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests to cover rollback allocation tokens flow
3 participants