Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blobber conductor tests #2884

Merged
merged 13 commits into from Oct 28, 2023

Conversation

devyetii
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@devyetii devyetii linked an issue Oct 21, 2023 that may be closed by this pull request
@devyetii devyetii changed the title Separate validators from blobbers in conductor testing Fix blobber conductor tests Oct 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (sprint-1.11@5b5afde). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@              Coverage Diff               @@
##             sprint-1.11    #2884   +/-   ##
==============================================
  Coverage               ?   28.71%           
==============================================
  Files                  ?      395           
  Lines                  ?    66327           
  Branches               ?        0           
==============================================
  Hits                   ?    19043           
  Misses                 ?    44972           
  Partials               ?     2312           
Flag Coverage Δ
Unit-Tests 28.71% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 4842fd7 into sprint-1.11 Oct 28, 2023
7 checks passed
@dabasov dabasov deleted the fix/separate-validator-for-conductor-testing branch October 28, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix blobber-2 conductor testing suite on staging branch
3 participants