New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test for get blobbers from params #2891
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## sprint-1.11 #2891 +/- ##
==============================================
Coverage ? 28.75%
==============================================
Files ? 395
Lines ? 66327
Branches ? 0
==============================================
Hits ? 19073
Misses ? 44944
Partials ? 2310
Flags with carried forward coverage won't be shown. Click here to find out more. |
@Jayashsatolia403 Please take a look at the values. |
@Jayashsatolia403 @dabasov However, it's failing in here. What could be the reason? Please let me know how I can fix this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete only the added blobbers. Also, use a cleanup function so that if it fails in the middle, it won't affect other tests.
Hey @Jayashsatolia403, I have updated the PR. Please have a look at this. Is this what you meant? |
@dabasov please take a look at the PR, I have added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@dabasov do I have to do anything? |
Fixes
This PR is not yet complete, I have created it as a draft
-> I have written the unit test for get blobbers from params
The am testing if everything goes alright with 1st blobbers then I will create all the other blobbers accordingly.
Changes
There are no changes apart from the blobbers_test file changes
Need to be mentioned in CHANGELOG.md?
I don't think so.
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):