Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#2824 cleaning geolocation #2905

Merged
merged 4 commits into from Oct 28, 2023
Merged

Conversation

tanishq67
Copy link
Contributor

@tanishq67 tanishq67 commented Oct 27, 2023

Fixes

This PR fixes this issue - #2824

Changes

I have cleaned up geolocation from the codebase.
Here are all the files that needed a change.
https://textb.org/t/fileszusgeoloaction/

All the unit tests are running over my system.

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@tanishq67
Copy link
Contributor Author

@dabasov Please have a look at this also, I created https://github.com/0chain/0chain/tree/CleanupGeolocation this branch before, however it is useless now.. could you please delete that as well after merging this PR

@tanishq67 tanishq67 linked an issue Oct 27, 2023 that may be closed by this pull request
@dabasov dabasov changed the base branch from staging to sprint-1.11 October 28, 2023 09:18
dabasov and others added 2 commits October 28, 2023 14:05
# Conflicts:
#	.gitignore
#	code/go/0chain.net/chaincore/smartcontract/handler_test.go
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (sprint-1.11@4842fd7). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@              Coverage Diff               @@
##             sprint-1.11    #2905   +/-   ##
==============================================
  Coverage               ?   28.76%           
==============================================
  Files                  ?      395           
  Lines                  ?    65842           
  Branches               ?        0           
==============================================
  Hits                   ?    18941           
  Misses                 ?    44606           
  Partials               ?     2295           
Flag Coverage Δ
Unit-Tests 28.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dabasov dabasov merged commit fd1ddfd into sprint-1.11 Oct 28, 2023
6 of 7 checks passed
@dabasov dabasov deleted the Issue#2824_CleaningGeolocation branch October 28, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up geolocation for a blobber in 0chain
3 participants