Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node recovery CT workflow #2918

Merged
merged 18 commits into from
Nov 6, 2023
Merged

Fix node recovery CT workflow #2918

merged 18 commits into from
Nov 6, 2023

Conversation

devyetii
Copy link
Collaborator

@devyetii devyetii commented Nov 1, 2023

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Merging #2918 (90cdacf) into staging (18e9fc5) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           staging    #2918      +/-   ##
===========================================
- Coverage    28.52%   28.50%   -0.02%     
===========================================
  Files          390      390              
  Lines        65606    65606              
===========================================
- Hits         18711    18702       -9     
- Misses       44653    44669      +16     
+ Partials      2242     2235       -7     
Flag Coverage Δ
Unit-Tests 28.50% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@devyetii
Copy link
Collaborator Author

devyetii commented Nov 6, 2023

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit cfc0956 into staging Nov 6, 2023
9 of 14 checks passed
@dabasov dabasov deleted the fix/node-recovery-wf branch November 6, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants