Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/diagnostic pages #2927

Merged
merged 4 commits into from Nov 5, 2023
Merged

Fix/diagnostic pages #2927

merged 4 commits into from Nov 5, 2023

Conversation

Jayashsatolia403
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2023

Codecov Report

Merging #2927 (8055888) into sprint-1.11 (b3c28a6) will increase coverage by 0.00%.
Report is 43 commits behind head on sprint-1.11.
The diff coverage is 52.17%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##           sprint-1.11    #2927   +/-   ##
============================================
  Coverage        28.80%   28.80%           
============================================
  Files              395      395           
  Lines            65842    65873   +31     
============================================
+ Hits             18967    18977   +10     
- Misses           44581    44596   +15     
- Partials          2294     2300    +6     
Flag Coverage Δ
Unit-Tests 28.80% <52.17%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
code/go/0chain.net/chaincore/chain/config.go 21.49% <100.00%> (+0.36%) ⬆️
code/go/0chain.net/core/config/config.go 0.00% <ø> (ø)
code/go/0chain.net/sharder/chain.go 3.71% <ø> (-0.21%) ⬇️
code/go/0chain.net/sharder/healthcheck_handler.go 100.00% <ø> (ø)
code/go/0chain.net/sharder/stats.go 89.38% <ø> (-0.40%) ⬇️
...ode/go/0chain.net/smartcontract/dbs/event/block.go 7.24% <100.00%> (ø)
code/go/0chain.net/smartcontract/storagesc/sc.go 42.02% <100.00%> (+0.62%) ⬆️
code/go/0chain.net/smartcontract/zcnsc/nodes.go 33.33% <100.00%> (+1.73%) ⬆️
...go/0chain.net/smartcontract/dbs/event/partition.go 76.00% <60.00%> (-10.67%) ⬇️
...o/0chain.net/smartcontract/dbs/event/authorizer.go 29.16% <0.00%> (-1.27%) ⬇️
... and 1 more

... and 5 files with indirect coverage changes

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit aa5e75d into sprint-1.11 Nov 5, 2023
7 checks passed
@dabasov dabasov deleted the fix/diagnostic-pages branch November 5, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants