Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race issue: Protect core.memorystore.pools #263 #316

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Race issue: Protect core.memorystore.pools #263 #316

merged 4 commits into from
Jun 2, 2021

Conversation

platsko
Copy link
Contributor

@platsko platsko commented May 25, 2021 •
edited

Closes #263

@platsko platsko requested review from Sriep and MurashovVen May 25, 2021 15:31
Sriep
Sriep reviewed Jun 1, 2021
View reviewed changes
Copy link
Contributor

@Sriep Sriep left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest only make changes needed for the pools object, and issue #263, leaving any changes to the connection code for issue #265.

In fact, it might be clearer to make a separate file for the pool object.

@Sriep Sriep marked this pull request as ready for review June 2, 2021 14:22
@Sriep
Copy link
Contributor

Sriep commented Jun 2, 2021

  • Split connections.go up. Created pool.go for the poolList type. Split up unit test.
  • Created poolList methods for the functions that needed poolList mutex.
  • Global functions changed to wrap poolList methods
  • Removed getConnectionCount which was not being used.
  • Some CamelCase refactoring.

@Sriep Sriep merged commit afa8b07 into master Jun 2, 2021
@Sriep Sriep deleted the issues/263 branch June 2, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriep Sriep Sriep approved these changes

@MurashovVen MurashovVen Awaiting requested review from MurashovVen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race issue: Protect core.memorystore.pools
2 participants
@platsko @Sriep