Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction error processing #3195

Merged
merged 37 commits into from
Mar 26, 2024
Merged

Fix transaction error processing #3195

merged 37 commits into from
Mar 26, 2024

Conversation

Jayashsatolia403
Copy link
Collaborator

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 28.77%. Comparing base (d25ab4f) to head (b06968e).

Files Patch % Lines
code/go/0chain.net/sharder/worker.go 0.00% 9 Missing ⚠️
.../0chain.net/smartcontract/dbs/event/transaction.go 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #3195      +/-   ##
===========================================
- Coverage    28.77%   28.77%   -0.01%     
===========================================
  Files          405      405              
  Lines        67151    67157       +6     
===========================================
+ Hits         19323    19324       +1     
- Misses       45490    45493       +3     
- Partials      2338     2340       +2     
Flag Coverage Δ
Unit-Tests 28.77% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov changed the base branch from staging to sprint-1.14 March 26, 2024 20:59
@dabasov dabasov added the v1.14 label Mar 26, 2024
@dabasov dabasov merged commit 6bbbd8c into sprint-1.14 Mar 26, 2024
5 of 6 checks passed
@dabasov dabasov deleted the fix/transaction-errors branch March 26, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants