Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix validator URL for aggregates #3271

Merged
merged 1 commit into from May 24, 2024
Merged

Conversation

devyetii
Copy link
Collaborator

@devyetii devyetii commented May 7, 2024

Fixes

validator_aggregates.url is not synced with validators.base_url which causes disappearance of URL field in 0box. This PR adds this sync + unit tests for it.

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@devyetii
Copy link
Collaborator Author

devyetii commented May 7, 2024

validator-urls.csv

Fixing old data in 0box

  • Create a new temp table filled with the data in the attached csv file. Let's call the table tmp_validator_urls
  • Run the following query
UPDATE provider SET url = tmp_validator_urls FROM tmp_validator_urls WHERE tmp_validator_urls.id = provider.provider_id

This fix needs to be applied AFTER this PR is merged and deployed on mainnet sharders, otherwise it will be overwritten from the incorrect data coming from the sharders.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit e0c71dc into staging May 24, 2024
4 of 7 checks passed
@dabasov dabasov deleted the hotfix/validator-aggregate-url branch May 24, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants