Bug in Shell Scripts #373
Merged
Bug in Shell Scripts #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sriep
approved these changes
Jun 22, 2021
peterlimg
added a commit
that referenced
this pull request
Jul 11, 2021
* master: (23 commits) 🐛 writePoolLock creats a new wrteipool if non exists (#383) ✨ Add immutable allocations (#375) ✨ Select diverse blobbers by geo location (#315) ✨ Blobber block rewards (#317) 📚 Unit test doc (#325) ✨ Free storage allocation (#358) Fixes for smart contract blobber add/update methods (#361) ✨ Add curator and transfer allocatin ownership (#366) read pool lock creat read pool (#377) add condition check to handle empty block hash #297 Update state_handler_test.go Update state_handler_test.go Update handler.go Bug in Shell Scripts (#373) Return empty list, if there is no challenges fixing issue that caused build fail more shell corrections Added M1 support to docker files (#351) updated shell files according to shellchecks (github.com/koalaman/shellcheck) readme fixes ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the bug referenced in #370
I have checked all the files in this #353, tried to run all the scripts, where there is a difference in behaviour and made the fixes accordingly!
Why it happened?
Since I did changes based on best practices, suggestions by shell check. I tested few scripts for which I had context and then assumed the changes are safe!
How to make sure issues like this won't occur again?
We can have a GitHub workflow which builds from the source and starts the servers. And then we can run integration tests. This should ensure the above.
I believe someone in the team is already working on it. so that's already taken care 😄