Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli):added dev.local #13

Merged
merged 5 commits into from
Jul 23, 2021
Merged

feat(cli):added dev.local #13

merged 5 commits into from
Jul 23, 2021

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Jul 20, 2021

Proposed changes

  • remove unused script on Dockerfile
  • improve build performance: move to go build on local instead of inside docker.
  • simplify testing and debugging with native binary instead of remote debugger inside docker

Types of changes

What types of changes does your code introduce to 0dns?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Documentation Update
  • Other (Please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

  • added ./dev.local/cli.sh for developer to setup local development && debugging environment
  • refactored code to make 0dns also can run outside docker
  • related changes with Add 0chain developer guide 0chain#287

@cnlangzi cnlangzi requested review from Sriep and removed request for anish-squareops July 21, 2021 08:05
Copy link
Contributor

@Sriep Sriep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the readme? Assume I am a new developer and follow the directions in readme.md.

# git submodule update && \
# make -j $(nproc) install && \
# cd - && \
# rm -R /tmp/bls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented-out code. It's still under source control if we want it back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Sriep Sriep merged commit 921ea3c into master Jul 23, 2021
@Sriep Sriep deleted the devlocal branch July 23, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants