Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split mutable config into global state #41

Merged
merged 2 commits into from
May 23, 2022

Conversation

avanaur
Copy link
Contributor

@avanaur avanaur commented May 21, 2022

Proposed changes

Resolves #39

Split mutable config data (CurrentMagicBlock, Miners, Shareders) from static config data. Moved the mutable data to a synchronized global state to avoid race condition

Go test race.

(cd code/go/0dns.io && go test -race ./...)
?       0dns.io/core/common     [no test files]
?       0dns.io/core/config     [no test files]
?       0dns.io/core/logging    [no test files]
ok      0dns.io/core/state      0.783s
?       0dns.io/zdnscore/worker [no test files]
?       0dns.io/zdnscore/zdns   [no test files]

Types of changes

What types of changes does your code introduce to 0dns?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Documentation Update
  • Other (Please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@avanaur avanaur marked this pull request as ready for review May 21, 2022 13:34
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit eeca2bc into staging May 23, 2022
@cnlangzi cnlangzi deleted the feature/split-mutable-config branch May 23, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config is not thread safe
2 participants