Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise PR in 0helm on config change #1011

Merged
merged 4 commits into from
Apr 10, 2023
Merged

raise PR in 0helm on config change #1011

merged 4 commits into from
Apr 10, 2023

Conversation

Manali-Jain-squareops
Copy link
Contributor

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Merging #1011 (cae72bf) into staging (47eecad) will not change coverage.
The diff coverage is n/a.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           staging    #1011   +/-   ##
========================================
  Coverage    27.73%   27.73%           
========================================
  Files           77       77           
  Lines         8091     8091           
========================================
  Hits          2244     2244           
  Misses        5556     5556           
  Partials       291      291           
Flag Coverage 螖
Unit-Tests 27.73% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterlimg peterlimg merged commit b9677ec into staging Apr 10, 2023
2 of 4 checks passed
@peterlimg peterlimg deleted the helm-config-pr branch April 10, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants