-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/readmarker issues #1019
Fix/readmarker issues #1019
Conversation
Send allocation id as query param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lpoli please fix UT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Remove redundant field
Codecov Report
馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## staging #1019 +/- ##
========================================
Coverage 27.73% 27.73%
========================================
Files 77 77
Lines 8091 8091
========================================
Hits 2244 2244
Misses 5556 5556
Partials 291 291
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Changes
Use client id and allocation id as composite primary key to distinguish readmarker for allocation by client.
Modify readmarker retrieving query for redeeming.
Request latest readmarker to chain if record is not found locally.
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):