Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/readmarker issues #1019

Merged
merged 5 commits into from
Apr 5, 2023
Merged

Fix/readmarker issues #1019

merged 5 commits into from
Apr 5, 2023

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Apr 4, 2023

Changes

Use client id and allocation id as composite primary key to distinguish readmarker for allocation by client.
Modify readmarker retrieving query for redeeming.
Request latest readmarker to chain if record is not found locally.

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterlimg
Copy link
Member

@lpoli please fix UT

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Remove redundant field
@codecov-commenter
Copy link

Codecov Report

Merging #1019 (bb3ae61) into staging (827e6e7) will not change coverage.
The diff coverage is 100.00%.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           staging    #1019   +/-   ##
========================================
  Coverage    27.73%   27.73%           
========================================
  Files           77       77           
  Lines         8091     8091           
========================================
  Hits          2244     2244           
  Misses        5556     5556           
  Partials       291      291           
Flag Coverage 螖
Unit-Tests 27.73% <100.00%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...et/blobbercore/handler/object_operation_handler.go 30.93% <100.00%> (酶)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dabasov dabasov merged commit f5f9b95 into staging Apr 5, 2023
5 checks passed
@dabasov dabasov deleted the fix/readmarker-issues branch April 5, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants