Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove register #1031

Merged
merged 13 commits into from
Apr 27, 2023
Merged

Fix/remove register #1031

merged 13 commits into from
Apr 27, 2023

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Apr 14, 2023

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/remove-register
zboxcli fix/remove-register
zwalletcli fix/remove-register
0chain remove-register_wallet-endpoint
blobber fix/remove-register
authorizer fix/remove-register
0box fix/remove-register
0dns staging

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/remove-register
zboxcli fix/remove-register
zwalletcli fix/remove-register
0chain remove-register_wallet-endpoint
blobber fix/remove-register
authorizer fix/remove-register
0box fix/remove-register
0dns staging

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests fix/remove-register
gosdk fix/remove-register
zboxcli fix/remove-register
zwalletcli fix/remove-register
0chain remove-register_wallet-endpoint
blobber fix/remove-register
authorizer fix/remove-register
0box fix/remove-register
0dns staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/remove-register
gosdk staging
zboxcli fix/remove-register
zwalletcli fix/remove-register
0chain remove-register_wallet-endpoint
blobber fix/remove-register
authorizer staging
0box staging
0dns staging

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Merging #1031 (651bbdb) into staging (a714b73) will increase coverage by 0.05%.
The diff coverage is n/a.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging    #1031      +/-   ##
===========================================
+ Coverage    27.77%   27.82%   +0.05%     
===========================================
  Files           77       77              
  Lines         8084     8069      -15     
===========================================
  Hits          2245     2245              
+ Misses        5548     5533      -15     
  Partials       291      291              
Flag Coverage 螖
Unit-Tests 27.82% <酶> (+0.05%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
code/go/0chain.net/blobbercore/handler/protocol.go 0.00% <酶> (酶)
...de/go/0chain.net/validatorcore/storage/protocol.go 0.00% <酶> (酶)

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/remove-register
gosdk fix/remove-register
zboxcli fix/remove-register
zwalletcli fix/remove-register
0chain remove-register_wallet-endpoint
blobber fix/remove-register
authorizer staging
0box fix/remove-register
0dns staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/remove-register
gosdk fix/remove-register
zboxcli fix/remove-register
zwalletcli fix/remove-register
0chain remove-register_wallet-endpoint
blobber fix/remove-register
authorizer fix/remove-register
0box fix/remove-register
0dns staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/remove-register
authorizer staging
0box staging
0dns staging

@Kishan-Dhakan Kishan-Dhakan merged commit 76a19ca into staging Apr 27, 2023
6 of 7 checks passed
@Kishan-Dhakan Kishan-Dhakan deleted the fix/remove-register branch April 27, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants