Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove lock request time #1046

Merged
merged 2 commits into from
May 3, 2023
Merged

Fix/remove lock request time #1046

merged 2 commits into from
May 3, 2023

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Apr 27, 2023

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix/remove-lock-request-time
zwalletcli staging
0chain staging
blobber fix/remove-lock-request-time
authorizer staging
0box staging
0dns staging

@dabasov
Copy link
Member Author

dabasov commented Apr 27, 2023

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1046 (523d21d) into staging (b971b86) will decrease coverage by 0.11%.
The diff coverage is 80.00%.

馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging    #1046      +/-   ##
===========================================
- Coverage    27.80%   27.69%   -0.11%     
===========================================
  Files           77       77              
  Lines         8073     8065       -8     
===========================================
- Hits          2245     2234      -11     
- Misses        5537     5544       +7     
+ Partials       291      287       -4     
Flag Coverage 螖
Unit-Tests 27.69% <80.00%> (-0.11%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...ode/go/0chain.net/blobbercore/writemarker/mutex.go 47.22% <75.00%> (-0.88%) 猬囷笍
...ain.net/blobbercore/handler/handler_writemarker.go 62.50% <100.00%> (-2.21%) 猬囷笍

... and 1 file with indirect coverage changes

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix/remove-lock-request-time
zwalletcli fix/remove-lock-request-time
0chain staging
blobber fix/remove-lock-request-time
authorizer staging
0box staging
0dns staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/remove-lock-request-time
authorizer staging
0box staging
0dns staging

@dabasov dabasov merged commit 958b7da into staging May 3, 2023
7 of 14 checks passed
@dabasov dabasov deleted the fix/remove-lock-request-time branch May 3, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants