New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resp msg in create conneciton obj api #1123
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## staging #1123 +/- ##
===========================================
- Coverage 26.49% 26.48% -0.02%
===========================================
Files 80 80
Lines 9034 9038 +4
===========================================
Hits 2394 2394
- Misses 6332 6336 +4
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Manual system tests [cancelled] with the following config
|
Changes
Create connection obj API was returning nil in every case, it was causing issue in wasm. In this PR, I have added some response message to API.
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):