Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resp msg in create conneciton obj api #1123

Merged
merged 4 commits into from Jun 13, 2023

Conversation

Roshan-Mehta
Copy link
Contributor

@Roshan-Mehta Roshan-Mehta commented Jun 10, 2023

Changes

Create connection obj API was returning nil in every case, it was causing issue in wasm. In this PR, I have added some response message to API.

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2023

Codecov Report

Merging #1123 (898d4b4) into staging (5c674bc) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           staging    #1123      +/-   ##
===========================================
- Coverage    26.49%   26.48%   -0.02%     
===========================================
  Files           80       80              
  Lines         9034     9038       +4     
===========================================
  Hits          2394     2394              
- Misses        6332     6336       +4     
  Partials       308      308              
Flag Coverage Δ
Unit-Tests 26.48% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
code/go/0chain.net/blobbercore/handler/handler.go 59.47% <0.00%> (ø)
...et/blobbercore/handler/object_operation_handler.go 22.07% <0.00%> (-0.08%) ⬇️

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped false
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/send-resp-create_connection
authorizer staging
0box staging
0dns staging

@dabasov dabasov merged commit 0cbd63c into staging Jun 13, 2023
4 of 7 checks passed
@dabasov dabasov deleted the fix/send-resp-create_connection branch June 13, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants