Fix chall cancel commit #1359
Merged
Fix chall cancel commit #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hitenjain14
requested review from
peterlimg,
dabasov and
guruhubb
as code owners
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## sprint-1.12 #1359 +/- ##
===============================================
- Coverage 23.65% 23.64% -0.02%
===============================================
Files 87 87
Lines 10094 10099 +5
===============================================
Hits 2388 2388
- Misses 7410 7415 +5
Partials 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dabasov
pushed a commit
that referenced
this pull request
Jan 21, 2024
* check prev root and add constraint (#1356) * Hotfix update allocation worker * Fix lint * Fix * Fixed updateAllocationInDB check as well * check prev root and add constraint * check if alloc is updated * rmv check --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> * add index for connection id (#1358) * Fix chall cancel commit (#1359) * fix challenge cancel commit * change conn lifetime * Fixed updateAllocationInDB check as well (#1357) * fix alloc lock for commit (#1363) * Fix get round (#1361) * check prev root and add constraint (#1356) * Hotfix update allocation worker * Fix lint * Fix * Fixed updateAllocationInDB check as well * check prev root and add constraint * check if alloc is updated * rmv check --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> * add index for connection id (#1358) * get round on start * fix hook --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> * fix alloc lock for commit * cleanup --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> * fix max objects in dir * fix ut * fix commit lock (#1365) --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> Co-authored-by: Jayash Satolia <73050737+Jayashsatolia403@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):