Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature blobber authorization #1393

Merged
merged 9 commits into from
Apr 7, 2024
Merged

Feature blobber authorization #1393

merged 9 commits into from
Apr 7, 2024

Conversation

Jayashsatolia403
Copy link
Collaborator

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Jayashsatolia403 Jayashsatolia403 linked an issue Feb 27, 2024 that may be closed by this pull request
6 tasks
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 13.63636% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 15.01%. Comparing base (7ce03e2) to head (047cc5b).

Files Patch % Lines
code/go/0chain.net/blobbercore/handler/handler.go 16.00% 20 Missing and 1 partial ⚠️
...e/go/0chain.net/blobbercore/handler/auth_ticket.go 0.00% 12 Missing ⚠️
code/go/0chain.net/core/common/admin.go 0.00% 4 Missing ⚠️
code/go/0chain.net/blobber/http.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #1393   +/-   ##
========================================
  Coverage    15.01%   15.01%           
========================================
  Files          178      179    +1     
  Lines        19908    19951   +43     
========================================
+ Hits          2989     2996    +7     
- Misses       16548    16583   +35     
- Partials       371      372    +1     
Flag Coverage Δ
Unit-Tests 15.01% <13.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jayashsatolia403 Jayashsatolia403 changed the base branch from staging to sprint-1.14 April 7, 2024 19:09
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 20b8614 into sprint-1.14 Apr 7, 2024
5 of 6 checks passed
@dabasov dabasov deleted the feature/blobber-auth branch April 7, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature blobber authorization
4 participants