Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/transaction nonce #585

Merged
merged 35 commits into from
May 9, 2022
Merged

Feature/transaction nonce #585

merged 35 commits into from
May 9, 2022

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Mar 14, 2022

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022

Codecov Report

Merging #585 (f640cc9) into staging (8ce0eac) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           staging     #585   +/-   ##
========================================
  Coverage    19.70%   19.70%           
========================================
  Files           66       66           
  Lines         7530     7530           
========================================
  Hits          1484     1484           
  Misses        5819     5819           
  Partials       227      227           
Flag Coverage 螖
Unit-Tests 19.70% <0.00%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
code/go/0chain.net/blobbercore/handler/zcncore.go 0.00% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8ce0eac...f640cc9. Read the comment docs.

@dabasov dabasov marked this pull request as ready for review May 9, 2022 20:01
@dabasov dabasov requested a review from cnlangzi May 9, 2022 20:01
@Kishan-Dhakan Kishan-Dhakan self-requested a review May 9, 2022 20:15
Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests feature/transaction-nonce
gosdk NOT OVERRIDDEN
zboxcli feature/transaction-nonce
zwalletcli feature/transaction-nonce
0chain feature/transaction_nonce
blobber feature/transaction-nonce
authorizer staging
0box feature/transaction-nonce
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@dabasov dabasov merged commit c666d22 into staging May 9, 2022
@cnlangzi cnlangzi deleted the feature/transaction-nonce branch January 29, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants