Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

- fix/challenges #648

Merged
merged 2 commits into from
May 9, 2022
Merged

- fix/challenges #648

merged 2 commits into from
May 9, 2022

Conversation

ssardana08
Copy link
Contributor

@ssardana08 ssardana08 commented Apr 21, 2022

Changes

  • fixed Issue with /getchallenge response unmarshalling

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@ssardana08 ssardana08 linked an issue Apr 21, 2022 that may be closed by this pull request
@ssardana08 ssardana08 mentioned this pull request Apr 21, 2022
3 tasks
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/challenges
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain fix/challenges
blobber fix/challenges
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@cnlangzi cnlangzi self-assigned this Apr 29, 2022
@cnlangzi
Copy link
Contributor

@sum-it08 I am working on this challenge issue for latest bbr. so just leave it with me , thanks.

@peterlimg
Copy link
Member

@cnlangzi @sum-it08 please describe the problem that the PR is going to resolve. Reviewers need to know what this PR for and what issues it will fix.

@ssardana08
Copy link
Contributor Author

@peterlimg I've added changes in PR description now.

@ssardana08
Copy link
Contributor Author

@sum-it08 I am working on this challenge issue for latest bbr. so just leave it with me , thanks.

@cnlangzi didn't get - what more changes needed?

@cnlangzi
Copy link
Contributor

cnlangzi commented May 5, 2022

@sum-it08 getting more errors on challenge, please check it on https://0chain.slack.com/archives/C020E8HA8TE/p1651723437262479?thread_ts=1650570070.706369&cid=C020E8HA8TE

@ssardana08 ssardana08 merged commit 8ce0eac into staging May 9, 2022
@ssardana08 ssardana08 deleted the fix/challenges branch May 9, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Challenges not getting stored in db
4 participants