Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/getblobber #666

Merged
merged 3 commits into from Apr 29, 2022
Merged

Fix/getblobber #666

merged 3 commits into from Apr 29, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Apr 29, 2022 •
edited

Changes

Fixes

  • used zcncore.GetBlobber instead sdk.GetBlobber. Because sdk.GetBlobber is designed for client. and zboxcore.InitStorageSDK must be invoked. it doesn't work for blobber

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@cnlangzi cnlangzi mentioned this pull request Apr 29, 2022
Merged
3 tasks
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/getblobber
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/getblobber
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

dabasov
dabasov approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/getblobber
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/getblobber
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi merged commit 246ba97 into staging Apr 29, 2022
@cnlangzi cnlangzi deleted the fix/getblobber branch April 29, 2022 14:01
@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cnlangzi @service-0chain @dabasov