Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add on_chain field on /file/stats/<alloc> endpoint response #669

Merged
merged 1 commit into from
May 6, 2022
Merged

Add on_chain field on /file/stats/<alloc> endpoint response #669

merged 1 commit into from
May 6, 2022

Conversation

avanaur
Copy link
Contributor

@avanaur avanaur commented May 5, 2022 •
edited

Changes

Add on_chain field on /file/stats/<alloc> endpoint response

Fixes

Fixes #107

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@avanaur avanaur marked this pull request as ready for review May 5, 2022 14:04
@avanaur avanaur requested a review from cnlangzi May 5, 2022 14:05
cnlangzi
cnlangzi approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit 902adcf into staging May 6, 2022
@cnlangzi cnlangzi deleted the feature/filestats_on_chain_fld branch May 6, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnlangzi cnlangzi cnlangzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Info, field on_cloud is False even though it has been committed
2 participants
@avanaur @cnlangzi