Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/delete requests #672

Merged
merged 10 commits into from
May 14, 2022
Merged

Fix/delete requests #672

merged 10 commits into from
May 14, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented May 6, 2022

Changes

  • moved form data to query string for delete delete request
  • moved form data to query string for get/delete collaborator requests
  • moved form data to query string for delete shareinfo

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #672 (71b19a2) into staging (6652c59) will increase coverage by 0.00%.
The diff coverage is 33.07%.

@@           Coverage Diff            @@
##           staging     #672   +/-   ##
========================================
  Coverage    19.64%   19.65%           
========================================
  Files           66       66           
  Lines         7559     7607   +48     
========================================
+ Hits          1485     1495   +10     
- Misses        5846     5885   +39     
+ Partials       228      227    -1     
Flag Coverage Δ
Unit-Tests 19.65% <33.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../go/0chain.net/blobbercore/handler/file_command.go 29.62% <0.00%> (ø)
...ain.net/blobbercore/handler/file_command_delete.go 0.00% <0.00%> (ø)
...ain.net/blobbercore/handler/file_command_update.go 0.00% <0.00%> (ø)
.../go/0chain.net/blobbercore/handler/grpc_handler.go 7.01% <0.00%> (-0.35%) ⬇️
.../0chain.net/blobbercore/handler/storage_handler.go 24.20% <21.73%> (-1.05%) ⬇️
...o/0chain.net/blobbercore/handler/handler_common.go 17.34% <22.22%> (-6.42%) ⬇️
...et/blobbercore/handler/object_operation_handler.go 32.85% <50.00%> (+0.30%) ⬆️
code/go/0chain.net/blobbercore/handler/handler.go 57.99% <88.88%> (+0.50%) ⬆️
...ain.net/blobbercore/handler/file_command_upload.go 44.52% <100.00%> (+0.77%) ⬆️
code/go/0chain.net/blobbercore/handler/helper.go 62.96% <100.00%> (+29.62%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6652c59...71b19a2. Read the comment docs.

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/delete_requests
zboxcli fix/delete_requests
zwalletcli staging
0chain staging
blobber fix/delete_requests
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi requested review from peterlimg and dabasov May 8, 2022 23:35
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/delete_requests
zboxcli fix/delete_requests
zwalletcli staging
0chain staging
blobber fix/delete_requests
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cnlangzi cnlangzi merged commit 89a6ab5 into staging May 14, 2022
@cnlangzi cnlangzi deleted the fix/delete_requests branch May 14, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Investigate the use of Request Body in DELETE http header request
4 participants