Delete thumbnail even if file is not to be deleted #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## staging #679 +/- ##
===========================================
+ Coverage 22.00% 22.02% +0.01%
===========================================
Files 69 69
Lines 7930 7933 +3
===========================================
+ Hits 1745 1747 +2
- Misses 5923 5924 +1
Partials 262 262
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cnlangzi
suggested changes
May 14, 2022
| @@ -76,7 +81,7 @@ func (nf *DeleteFileChange) CommitToFileStore(ctx context.Context) error { | |||
| Where("allocation_id=? AND content_hash=?", nf.AllocationID, res.ContentHash). | |||
| Count(&count) | |||
|
|
|||
| if count != 0 { | |||
| if count != 0 && res.ThumbnailHash == "" { | |||
There was a problem hiding this comment.
I would suggest to use res.ThumbnailSize ==0 instead of res.ThumbnailHash == ""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Even if there are content sharing
refs, they are not supposed to sharethumbnail. So if delete operation is called, thumbnail should be deleted regardless