Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gomod):upgrade gosdk and grpc #683

Merged
merged 9 commits into from
May 27, 2022
Merged

fix(gomod):upgrade gosdk and grpc #683

merged 9 commits into from
May 27, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented May 17, 2022

Changes

Fixes

  • upgraded gosdk & grpc

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #683 (9dd7522) into staging (845a97e) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           staging     #683      +/-   ##
===========================================
+ Coverage    23.99%   24.00%   +0.01%     
===========================================
  Files           69       69              
  Lines         7982     7976       -6     
===========================================
  Hits          1915     1915              
+ Misses        5782     5776       -6     
  Partials       285      285              
Flag Coverage 螖
Unit-Tests 24.00% <0.00%> (+0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
code/go/0chain.net/blobbercore/handler/protocol.go 0.00% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 845a97e...9dd7522. Read the comment docs.

Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain fix/retry_postgres
blobber fix/upgrade_deps_0517
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@cnlangzi cnlangzi closed this May 25, 2022
@cnlangzi cnlangzi deleted the fix/upgrade_deps_0517 branch May 25, 2022 01:31
@cnlangzi cnlangzi restored the fix/upgrade_deps_0517 branch May 25, 2022 01:31
@cnlangzi cnlangzi reopened this May 25, 2022
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/consensus_bug
zboxcli staging
zwalletcli fix/consensus_bug
0chain staging
blobber fix/upgrade_deps_0517
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi merged commit 5547a1c into staging May 27, 2022
@cnlangzi cnlangzi deleted the fix/upgrade_deps_0517 branch May 27, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants