Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(token): added QuoteQuery #714

Merged
merged 11 commits into from
Jun 8, 2022
Merged

fix(token): added QuoteQuery #714

merged 11 commits into from
Jun 8, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Jun 3, 2022

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #714 (6c0d4c2) into staging (5eafd9a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           staging     #714   +/-   ##
========================================
  Coverage    24.18%   24.18%           
========================================
  Files           69       69           
  Lines         7905     7905           
========================================
  Hits          1912     1912           
  Misses        5708     5708           
  Partials       285      285           
Flag Coverage 螖
Unit-Tests 24.18% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5eafd9a...6c0d4c2. Read the comment docs.

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/currency_api
zboxcli staging
zwalletcli fix/currency_api
0chain staging
blobber fix/currency_api
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/currency_api
zboxcli staging
zwalletcli fix/currency_api
0chain staging
blobber fix/currency_api
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi merged commit ee6faea into staging Jun 8, 2022
@cnlangzi cnlangzi deleted the fix/currency_api branch June 8, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiple API providers to convert ZCN to USD
4 participants