You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR will remove setting of payer_id field. All the reads in an allocation will be paid by allocation owner. Therefore, who_pays attribute is removed from code as well.
Fixes
Tests
Tasks to complete before merging PR:
Ensure system tests are passing. If not Run them manually to check for any regressions 📋
Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
Merge your system tests PR to master AFTER merging this PR
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR will remove setting of
payer_id
field. All the reads in an allocation will be paid by allocation owner. Therefore,who_pays
attribute is removed from code as well.Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):