Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update attributes #717

Merged
merged 20 commits into from Jul 4, 2022
Merged

Fix/update attributes #717

merged 20 commits into from Jul 4, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Jun 7, 2022

Changes

This PR will remove setting of payer_id field. All the reads in an allocation will be paid by allocation owner. Therefore, who_pays attribute is removed from code as well.

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #717 (a3c6fff) into staging (6b072d0) will decrease coverage by 0.13%.
The diff coverage is 56.52%.

@@             Coverage Diff             @@
##           staging     #717      +/-   ##
===========================================
- Coverage    24.15%   24.01%   -0.14%     
===========================================
  Files           69       68       -1     
  Lines         7913     7653     -260     
===========================================
- Hits          1911     1838      -73     
+ Misses        5718     5548     -170     
+ Partials       284      267      -17     
Flag Coverage Δ
Unit-Tests 24.01% <56.52%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain.net/blobbercore/allocation/allocationchange.go 0.00% <ø> (ø)
...chain.net/blobbercore/allocation/copyfilechange.go 45.65% <ø> (-0.78%) ⬇️
...ode/go/0chain.net/blobbercore/allocation/entity.go 0.00% <ø> (ø)
...in.net/blobbercore/allocation/file_changer_base.go 47.36% <ø> (ø)
....net/blobbercore/allocation/file_changer_update.go 58.33% <ø> (+2.65%) ⬆️
...0chain.net/blobbercore/allocation/newfilechange.go 28.02% <ø> (+0.60%) ⬆️
code/go/0chain.net/blobbercore/handler/handler.go 57.07% <ø> (-0.93%) ⬇️
...obbercore/handler/object_operation_grpc_handler.go 0.00% <ø> (ø)
code/go/0chain.net/blobbercore/reference/entity.go 77.77% <ø> (ø)
code/go/0chain.net/blobbercore/reference/ref.go 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b072d0...a3c6fff. Read the comment docs.

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/update-attributes
gosdk fix/update-attributes
zboxcli fix/update-attributes
zwalletcli fix/update-attributes
0chain staging
blobber fix/update-attributes
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/update-attributes
gosdk fix/update-attributes
zboxcli fix/update-attributes
zwalletcli fix/update-attributes
0chain staging
blobber fix/update-attributes
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/update-attributes
gosdk fix/update-attributes
zboxcli fix/update-attributes
zwalletcli fix/update-attributes
0chain fix/update-attributes
blobber fix/update-attributes
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/update-attributes
gosdk NOT OVERRIDDEN
zboxcli fix/update-attributes
zwalletcli fix/update-attributes
0chain staging
blobber fix/update-attributes
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@lpoli lpoli merged commit 28ea8c0 into staging Jul 4, 2022
@lpoli lpoli deleted the fix/update-attributes branch July 4, 2022 03:44
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement update-attributes --who-pays-for-reads
5 participants