Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blobber): fixed Used/ Allocated #720

Merged
merged 3 commits into from
Jun 21, 2022
Merged

fix(blobber): fixed Used/ Allocated #720

merged 3 commits into from
Jun 21, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Jun 10, 2022

Fixes

Changes

  • renamed Used with Allocation on blobber node
  • fixed Used for storage that is actually used by the client

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2022

Codecov Report

Merging #720 (dd33e4f) into staging (7440aa2) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           staging     #720      +/-   ##
===========================================
+ Coverage    24.13%   24.19%   +0.06%     
===========================================
  Files           69       69              
  Lines         7898     7898              
===========================================
+ Hits          1906     1911       +5     
+ Misses        5708     5703       -5     
  Partials       284      284              
Flag Coverage 螖
Unit-Tests 24.19% <酶> (+0.06%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
code/go/0chain.net/core/lock/lock.go 100.00% <0.00%> (+13.51%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7440aa2...dd33e4f. Read the comment docs.

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/getblobbers
gosdk fix/getblobbers
zboxcli fix/getblobbers
zwalletcli fix/getblobbers
0chain fix/getblobbers
blobber fix/getblobbers
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/getblobbers
gosdk fix/getblobbers
zboxcli fix/getblobbers
zwalletcli fix/getblobbers
0chain fix/getblobbers
blobber fix/getblobbers
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi requested a review from peterlimg June 16, 2022 23:01
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please fix conflicts

@cnlangzi cnlangzi merged commit cbe3d88 into staging Jun 21, 2022
@cnlangzi cnlangzi deleted the fix/getblobbers branch June 21, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants