-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compatble with gosdk head. #729
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #729 +/- ##
========================================
Coverage 24.19% 24.19%
========================================
Files 69 69
Lines 7899 7899
========================================
Hits 1911 1911
Misses 5704 5704
Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to change the Terms.ReadPrice
to uint64 and val
to uint64 in ExecuteSmartContract
instead of doing type casting. Anyway, we need to fix this for all the gosdk users.
Changes
Previous goSDK PRs have made blobber incompatible with GosdK head. This should fix that.
Upcoming write pool PRs will make braking changes and require blobber to work with the latest GoSDK.
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):