Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatble with gosdk head. #729

Merged
merged 6 commits into from
Jun 17, 2022
Merged

Make compatble with gosdk head. #729

merged 6 commits into from
Jun 17, 2022

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented Jun 17, 2022

Changes

Previous goSDK PRs have made blobber incompatible with GosdK head. This should fix that.

Upcoming write pool PRs will make braking changes and require blobber to work with the latest GoSDK.

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #729 (a0cc59e) into staging (8fd5fab) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           staging     #729   +/-   ##
========================================
  Coverage    24.19%   24.19%           
========================================
  Files           69       69           
  Lines         7899     7899           
========================================
  Hits          1911     1911           
  Misses        5704     5704           
  Partials       284      284           
Flag Coverage Δ
Unit-Tests 24.19% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
code/go/0chain.net/blobbercore/handler/protocol.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd5fab...a0cc59e. Read the comment docs.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit a98ac1a into staging Jun 17, 2022
@Sriep Sriep deleted the fix_mismatch branch June 17, 2022 13:13
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the Terms.ReadPrice to uint64 and val to uint64 in ExecuteSmartContract instead of doing type casting. Anyway, we need to fix this for all the gosdk users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants