Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update provider enum to start from 1 #733

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Update provider enum to start from 1 #733

merged 3 commits into from
Jun 22, 2022

Conversation

peterlimg
Copy link
Member

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2022

Codecov Report

Merging #733 (b8d5e21) into staging (cbe3d88) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           staging     #733      +/-   ##
===========================================
+ Coverage    24.13%   24.19%   +0.06%     
===========================================
  Files           69       69              
  Lines         7898     7898              
===========================================
+ Hits          1906     1911       +5     
+ Misses        5708     5703       -5     
  Partials       284      284              
Flag Coverage 螖
Unit-Tests 24.19% <酶> (+0.06%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
code/go/0chain.net/core/lock/lock.go 100.00% <0.00%> (+13.51%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update cbe3d88...b8d5e21. Read the comment docs.

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/getUsersPool
gosdk NOT OVERRIDDEN
zboxcli fix/getUsersPool
zwalletcli fix/getUsersPool
0chain fix/getUserPools
blobber fix/getUsersPool
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/getUsersPool
gosdk fix/getUsersPool
zboxcli fix/getUsersPool
zwalletcli fix/getUsersPool
0chain fix/getUserPools
blobber fix/getUsersPool
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/getUsersPool
gosdk fix/getUsersPool
zboxcli fix/getUsersPool
zwalletcli fix/getUsersPool
0chain fix/getUserPools
blobber fix/getUsersPool
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/getUsersPool
gosdk NOT OVERRIDDEN
zboxcli fix/getUsersPool
zwalletcli fix/getUsersPool
0chain fix/getUserPools
blobber fix/getUsersPool
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@peterlimg peterlimg merged commit 8ef0832 into staging Jun 22, 2022
@cnlangzi cnlangzi deleted the fix/getUsersPool branch January 29, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants