Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(challenge): extend logs on commit stage #781

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Aug 5, 2022

Changes

  • extended logs on challenge commit stage

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

Codecov Report

Merging #781 (412b1f0) into staging (9658eb1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           staging     #781   +/-   ##
========================================
  Coverage    24.40%   24.40%           
========================================
  Files           77       77           
  Lines         7829     7829           
========================================
  Hits          1911     1911           
  Misses        5651     5651           
  Partials       267      267           
Flag Coverage 螖
Unit-Tests 24.40% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cnlangzi cnlangzi merged commit a0f9f20 into staging Aug 5, 2022
@cnlangzi cnlangzi deleted the fix/extend_logs_challenge_commit branch August 5, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants