Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minio feature #823

Merged
merged 9 commits into from
Oct 26, 2022
Merged

Remove minio feature #823

merged 9 commits into from
Oct 26, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Sep 10, 2022

Changes

This PR will solve #797

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@lpoli lpoli requested a review from cnlangzi September 10, 2022 06:21
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2022

Codecov Report

Merging #823 (5e3bf76) into staging (d5638af) will increase coverage by 0.62%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           staging     #823      +/-   ##
===========================================
+ Coverage    25.57%   26.19%   +0.62%     
===========================================
  Files           77       76       -1     
  Lines         7856     7646     -210     
===========================================
- Hits          2009     2003       -6     
+ Misses        5584     5379     -205     
- Partials       263      264       +1     
Flag Coverage 螖
Unit-Tests 26.19% <50.00%> (+0.62%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...o/0chain.net/blobbercore/filestore/file_manager.go 5.26% <酶> (+0.50%) 猬嗭笍
.../go/0chain.net/blobbercore/filestore/mock_store.go 0.00% <酶> (酶)
code/go/0chain.net/blobbercore/filestore/state.go 70.28% <酶> (-0.22%) 猬囷笍
code/go/0chain.net/blobbercore/filestore/store.go 0.00% <酶> (酶)
...ain.net/blobbercore/handler/file_command_update.go 0.00% <0.00%> (酶)
...et/blobbercore/handler/object_operation_handler.go 35.15% <酶> (-0.04%) 猬囷笍
code/go/0chain.net/blobbercore/handler/worker.go 0.00% <酶> (酶)
code/go/0chain.net/blobbercore/reference/ref.go 0.00% <酶> (酶)
...ode/go/0chain.net/blobbercore/filestore/storage.go 41.83% <50.00%> (+1.91%) 猬嗭笍
...ain.net/blobbercore/handler/file_command_upload.go 42.00% <100.00%> (-0.39%) 猬囷笍
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber remove/minio-feature
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterlimg
Copy link
Member

@lpoli this PR requires the changes of 0helm to update the deployment script

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber remove/minio-feature
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@lpoli lpoli merged commit aa49a30 into staging Oct 26, 2022
@lpoli lpoli deleted the remove/minio-feature branch October 26, 2022 13:26
@lpoli lpoli linked an issue Oct 30, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minio feature should be removed
5 participants