Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to recent refs for owner only #853

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Oct 17, 2022

Fixes

Allow access to recent-refs api to allocation owner only.

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@lpoli lpoli requested a review from peterlimg October 17, 2022 14:00
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests feature/recent-refs
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/limit-access-on-recent-refs
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@peterlimg
Copy link
Member

lgtm, @lpoli please fix the system tests

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests feature/recent-refs
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/limit-access-on-recent-refs
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpoli lpoli merged commit b8b78e6 into staging Oct 28, 2022
@lpoli lpoli deleted the fix/limit-access-on-recent-refs branch October 28, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants