Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove GetObjectPath API #863

Merged
merged 2 commits into from
Oct 26, 2022
Merged

remove GetObjectPath API #863

merged 2 commits into from
Oct 26, 2022

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Oct 25, 2022

Changes

The GetObjectPath is not used anywhere and this can be removed
#859 (comment)

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Merging #863 (9470129) into staging (cdfe378) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           staging     #863      +/-   ##
===========================================
- Coverage    25.72%   25.55%   -0.18%     
===========================================
  Files           72       72              
  Lines         7906     7831      -75     
===========================================
- Hits          2034     2001      -33     
+ Misses        5601     5567      -34     
+ Partials       271      263       -8     
Flag Coverage 螖
Unit-Tests 25.55% <酶> (-0.18%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
.../go/0chain.net/blobbercore/handler/grpc_handler.go 8.63% <酶> (+0.89%) 猬嗭笍
code/go/0chain.net/blobbercore/handler/handler.go 64.47% <酶> (-0.81%) 猬囷笍
.../0chain.net/blobbercore/handler/storage_handler.go 22.55% <酶> (-1.24%) 猬囷笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@boddumanohar boddumanohar mentioned this pull request Oct 25, 2022
3 tasks
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants